[libvirt] [PATCH] build: link virstoragetest with libxml

[Martin Kletzander]

On Mon, Jun 23, 2014 at 04:08:42PM +0200, Martin Kletzander wrote:
>Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>---
>
>Notes:
>    To be honest, I have no idea why this fails for me in one situation,
>    but it prevents the following error during compilation:
>
>    /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/../../../../x86_64-pc-linux-gnu/bin/ld: ../src/.libs/libvirt_driver_storage_impl.a(libvirt_driver_storage_impl_la-storage_backend.o): undefined reference to symbol 'xmlFreeDoc@@LIBXML2_2.4.30'
>    /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/../../../../lib64/libxml2.so: error adding symbols: DSO missing from command line
>    collect2: error: ld returned 1 exit status
>    Makefile:4228: recipe for target 'virstoragetest' failed
>
>    Therefore I'm not pushing it as a build-breaker since this might not
>    be the root cause or the best solution.
>
>    The other fix (and probably more appropriate one) would be to add
>    LIBXML_LIBS into libvirt_conf_la_LIBADD since the xmlFreeDoc() is
>    called in storage_conf.c.
>
>    Any other preferred way is accepted as well, feel free to comment.
>
> tests/Makefile.am | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tests/Makefile.am b/tests/Makefile.am
>index 025b847..457eb99 100644
>--- a/tests/Makefile.am
>+++ b/tests/Makefile.am
>@@ -899,6 +899,7 @@ virstoragetest_LDADD = $(LDADDS) \
> 	../src/libvirt_util.la \
> 	../src/libvirt_driver_storage_impl.la \
> 	../gnulib/lib/libgnu.la \
>+	$(LIBXML_LIBS)		\
> 	$(NULL)
>
> viridentitytest_SOURCES = \
>--
>2.0.0
>

Ping?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140626/c47d96f1/attachment-0001.sig>