[libvirt] [PATCHv8 0/2] Implement RBD storage pool support

Adam Walters adam at pandorasboxen.com
Mon Mar 3 16:43:50 UTC 2014


This is an updated version of my RBD storage pool support patch. Relevant
changes since v7 are:
  - Fixed bug where I compared disk->srcpool->mode to VIR_DOMAIN_DISK_TYPE_NETWORK

In response to a couple of items Ján mentioned, I decided not to pursue adding
anything to qemuxml2argvtest. The reason I decided not to pursue this is there is
not really any need. In comparison with other volume types, RBD already has the
same test coverage. Namely, a base set of test-cases without using storage pools,
plus a generic storage pool test.

In addition, I also attempted to implement a proper check for expected vs actual
secret usage, but at that particular point in the code, Ján was correct that the
pool definition has not yet been parsed. Thus, I had to keep my bypass.

Adam Walters (2):
  qemu: conf Implement domain RBD storage pool support
  domain: conf: Fix secret type checking for network volumes

 src/conf/domain_conf.c |  9 ++++++--
 src/qemu/qemu_conf.c   | 62 +++++++++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 68 insertions(+), 3 deletions(-)

-- 
1.8.5.3




More information about the libvir-list mailing list