[libvirt] [PATCH] build: work around FreeBSD stdlib.h bug

Eric Blake eblake at redhat.com
Tue Mar 4 13:28:17 UTC 2014


POSIX requires that <stdlib.h> expose WIFEXITED and friends,
but FreeBSD and others fail to comply.  We can work around it
manually by including <sys/wait.h>, or we can work around it
automatically by using gnulib's system-posix module.

* bootstrap.conf (gnulib_modules): Add system-posix.

Signed-off-by: Eric Blake <eblake at redhat.com>
---

I'll wait for a review on this one - we don't use system(),
and it feels a little bit odd to list the system() module
merely for its side effect of a fixed <stdlib.h>.  The alternative
is to continue using <sys/wait.h> everywhere that we use
WIFEXITED and friends.

 bootstrap.conf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index d24a714..bc6ce80 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -1,6 +1,6 @@
 # Bootstrap configuration.

-# Copyright (C) 2010-2013 Red Hat, Inc.
+# Copyright (C) 2010-2014 Red Hat, Inc.

 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
@@ -112,6 +112,7 @@ strerror_r-posix
 strptime
 strsep
 strtok_r
+system-posix
 sys_stat
 sys_wait
 termios
-- 
1.8.5.3




More information about the libvir-list mailing list