[libvirt] [PATCH 2/7] Refactor code that skips logging of error messages

Eric Blake eblake at redhat.com
Wed Mar 5 00:32:50 UTC 2014


On 03/03/2014 12:18 PM, Daniel P. Berrange wrote:
> The virRaiseErrorFull method sends all error messages onto the

s/onto/on to/

> logging code. The logging code has some logic to skip emission
> when no log outputs are configured which checks the virLogSource.
> This will complicate later refactoring, and the check can easily
> be done in the virRaiseErrorFull method instead of in the logging
> code.
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  src/util/virerror.c | 14 ++++++++++----
>  src/util/virlog.c   |  2 +-
>  2 files changed, 11 insertions(+), 5 deletions(-)
> 

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140304/6f1f072d/attachment-0001.sig>


More information about the libvir-list mailing list