[libvirt] [PATCH] qemu: monitor: Provide more information in generic block job error

[Peter Krempa]

On 03/05/14 16:49, Eric Blake wrote:
> On 03/05/2014 07:15 AM, Peter Krempa wrote:
>> The qemuMonitorJSONBlockJob handles a few errors internally. If qemu
>> returns a different error we would report a rather unhelpful message:
>>
>>  $ virsh blockpull gluster-job vda --base /dev/null
>>  error: internal error: Unexpected error
>>
>> As the actual message from qemu contains a bit more info, let's use it
>> to report something a little more useful:
>>
>>  $ virsh blockpull gluster-job vda --base /dev/null
>>  error: internal error: Unexpected error: (GenericError) 'Base '/dev/null' not found'
> 
> The fact that we're reporting an internal error instead of catching it
> up front and avoiding the monitor command in the first place is a bit
> worrisome (ideally, we should be tracking the backing chain ourselves,
> and have some clue that qemu can't succeed because the input the user
> gave was not part of the chain).  But fixing _that_ is a bigger task,
> and meanwhile, this patch definitely improves the error quality by
> reflecting qemu's complaints.
> 
> For that matter, the fact that it is so easy to trigger an internal
> error is a bit worrisome, but I don't know if we have a better error
> category to use.
> 
>> ---
>>  src/qemu/qemu_monitor_json.c | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> ACK.
> 

Pushed; Thanks.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140305/3bc16c24/attachment-0001.sig>