[libvirt] [PATCH] spec: Let translations be properly updated

[Eric Blake]

On 03/06/2014 04:06 AM, Jiri Denemark wrote:
> Libvirt tarball contains po/stamp-po file which prevents any po/*.gmo
> file to be regenerated even if a corresponding po/*.po file is newer. By
> removing the stamp-po file, all *.gmo files are properly updated if
> required. This allows downstreams to provide patches that update
> translations.
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  libvirt.spec.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 014fe5d..23374e7 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -1421,6 +1421,7 @@ driver
>   autoreconf -if
>  %endif

I think you need to guard this:

>  
%if 0%{?enable_autotools}
> +rm -f po/stamp-po
%endif

>  %configure %{?_without_xen} \
>             %{?_without_qemu} \
>             %{?_without_openvz} \
> 

since regeneration of .po files only occurs if autotools are re-run.
When building an rpm from a stock tarball, you do NOT want to require
gettext to be present - it is only when you are applying downstream
patches that a .po file will ever be newer to require the regeneration
of translations.

ACK with the conditional added

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140306/787699f7/attachment-0001.sig>