[libvirt] [PATCH] spec: Let translations be properly updated

[Eric Blake]

On 03/06/2014 06:37 AM, Jiri Denemark wrote:
> On Thu, Mar 06, 2014 at 06:20:37 -0700, Eric Blake wrote:
>> On 03/06/2014 04:06 AM, Jiri Denemark wrote:
>>> Libvirt tarball contains po/stamp-po file which prevents any po/*.gmo
>>> file to be regenerated even if a corresponding po/*.po file is newer. By
>>> removing the stamp-po file, all *.gmo files are properly updated if
>>> required. This allows downstreams to provide patches that update
>>> translations.

>>
>> I think you need to guard this:
>>
>>>  
>> %if 0%{?enable_autotools}
>>> +rm -f po/stamp-po
>> %endif
> 
> I don't think so.
> 

> gettext is an unconditional BuildRequires in libvirt.spec so we always
> require it to be present (unlike gettext-devel which is only required if
> enable_autotools is 1). And msgfmt used for generating gmo files from po
> files is present in gettext package.

Fair enough.  ACK to your patch as-is, then.

> 
> And the Makefile from gettext is clever enough not to regenerate gmo
> files if their corresponding po files were not updated even if stamp-po
> is missing. That said, I don't really understand why stamp-po exists at
> all :-)

It exists for incremental development - so that 'make' doesn't rebuild
.gmo files for every source change.  I don't know why automake packages
it in the tarball, but that's a question for automake people (I'm not as
familiar with automake internals as I am with autoconf).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140306/fe102513/attachment-0001.sig>