[libvirt] [PATCH 5/9] conf: eliminate hardcoded indentation in nwfilter xml
Laine Stump
laine at laine.org
Thu Mar 6 15:24:28 UTC 2014
This file was using multiple virBuffers, inserting the contents of
buf3 into buf2, then inserting the contents of buf2 into buf1, rather
than the more conventional method of just passing around a single
virBufferPtr and streaming everything into that single buffer. This
was unnecessary, and also made it more difficult to make indentation
relative, because when you insert a string into a buffer, the
indentation of the buffer is only applied once at the beginning of the
string, *not* each time a newline is encountered in the string.
---
src/conf/nwfilter_conf.c | 94 ++++++++++++++--------------------------------
src/conf/nwfilter_params.c | 6 ++-
2 files changed, 32 insertions(+), 68 deletions(-)
diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c
index 52e1c06..588261c 100644
--- a/src/conf/nwfilter_conf.c
+++ b/src/conf/nwfilter_conf.c
@@ -2,7 +2,7 @@
* nwfilter_conf.c: network filter XML processing
* (derived from storage_conf.c)
*
- * Copyright (C) 2006-2013 Red Hat, Inc.
+ * Copyright (C) 2006-2014 Red Hat, Inc.
* Copyright (C) 2006-2008 Daniel P. Berrange
*
* Copyright (C) 2010-2011 IBM Corporation
@@ -3215,7 +3215,7 @@ virNWFilterRuleDefDetailsFormat(virBufferPtr buf,
enum virNWFilterEntryItemFlags flags = item->flags;
if ((flags & NWFILTER_ENTRY_ITEM_FLAG_EXISTS)) {
if (!typeShown) {
- virBufferAsprintf(buf, " <%s", type);
+ virBufferAsprintf(buf, "<%s", type);
typeShown = true;
neverShown = false;
}
@@ -3326,95 +3326,59 @@ virNWFilterRuleDefDetailsFormat(virBufferPtr buf,
if (neverShown)
virBufferAsprintf(buf,
- " <%s/>\n", type);
+ "<%s/>\n", type);
err_exit:
return;
}
-static char *
-virNWFilterRuleDefFormat(virNWFilterRuleDefPtr def)
+static int
+virNWFilterRuleDefFormat(virBufferPtr buf, virNWFilterRuleDefPtr def)
{
size_t i;
- virBuffer buf = VIR_BUFFER_INITIALIZER;
- virBuffer buf2 = VIR_BUFFER_INITIALIZER;
- char *data;
+ bool subelement = false;
- virBufferAsprintf(&buf, " <rule action='%s' direction='%s' priority='%d'",
+ virBufferAsprintf(buf, "<rule action='%s' direction='%s' priority='%d'",
virNWFilterRuleActionTypeToString(def->action),
virNWFilterRuleDirectionTypeToString(def->tt),
def->priority);
if ((def->flags & RULE_FLAG_NO_STATEMATCH))
- virBufferAddLit(&buf, " statematch='false'");
+ virBufferAddLit(buf, " statematch='false'");
+ virBufferAdjustIndent(buf, 2);
i = 0;
while (virAttr[i].id) {
if (virAttr[i].prtclType == def->prtclType) {
- virNWFilterRuleDefDetailsFormat(&buf2,
+ if (!subelement)
+ virBufferAddLit(buf, ">\n");
+ virNWFilterRuleDefDetailsFormat(buf,
virAttr[i].id,
virAttr[i].att,
def);
+ subelement = true;
break;
}
i++;
}
- if (virBufferError(&buf2))
- goto no_memory;
-
- data = virBufferContentAndReset(&buf2);
-
- if (data) {
- virBufferAddLit(&buf, ">\n");
- virBufferAsprintf(&buf, "%s </rule>\n", data);
- VIR_FREE(data);
- } else
- virBufferAddLit(&buf, "/>\n");
-
- if (virBufferError(&buf))
- goto no_memory;
-
- return virBufferContentAndReset(&buf);
-
-no_memory:
- virReportOOMError();
- virBufferFreeAndReset(&buf);
- virBufferFreeAndReset(&buf2);
-
- return NULL;
-}
-
-
-static char *
-virNWFilterIncludeDefFormat(virNWFilterIncludeDefPtr inc)
-{
- virBuffer buf = VIR_BUFFER_INITIALIZER;
-
- virBufferAdjustIndent(&buf, 2);
- if (virNWFilterFormatParamAttributes(&buf, inc->params,
- inc->filterref) < 0) {
- virBufferFreeAndReset(&buf);
- return NULL;
- }
- virBufferAdjustIndent(&buf, -2);
- if (virBufferError(&buf)) {
- virReportOOMError();
- virBufferFreeAndReset(&buf);
- return NULL;
- }
-
- return virBufferContentAndReset(&buf);
+ virBufferAdjustIndent(buf, -2);
+ if (subelement)
+ virBufferAddLit(buf, "</rule>\n");
+ else
+ virBufferAddLit(buf, "/>\n");
+ return 0;
}
-static char *
-virNWFilterEntryFormat(virNWFilterEntryPtr entry)
+static int
+virNWFilterEntryFormat(virBufferPtr buf, virNWFilterEntryPtr entry)
{
if (entry->rule)
- return virNWFilterRuleDefFormat(entry->rule);
- return virNWFilterIncludeDefFormat(entry->include);
+ return virNWFilterRuleDefFormat(buf, entry->rule);
+ return virNWFilterFormatParamAttributes(buf, entry->include->params,
+ entry->include->filterref);
}
@@ -3424,7 +3388,6 @@ virNWFilterDefFormat(const virNWFilterDef *def)
virBuffer buf = VIR_BUFFER_INITIALIZER;
char uuid[VIR_UUID_STRING_BUFLEN];
size_t i;
- char *xml;
virBufferAsprintf(&buf, "<filter name='%s' chain='%s'",
def->name,
@@ -3433,18 +3396,17 @@ virNWFilterDefFormat(const virNWFilterDef *def)
virBufferAsprintf(&buf, " priority='%d'",
def->chainPriority);
virBufferAddLit(&buf, ">\n");
+ virBufferAdjustIndent(&buf, 2);
virUUIDFormat(def->uuid, uuid);
- virBufferAsprintf(&buf, " <uuid>%s</uuid>\n", uuid);
+ virBufferAsprintf(&buf, "<uuid>%s</uuid>\n", uuid);
for (i = 0; i < def->nentries; i++) {
- xml = virNWFilterEntryFormat(def->filterEntries[i]);
- if (!xml)
+ if (virNWFilterEntryFormat(&buf, def->filterEntries[i]) < 0)
goto err_exit;
- virBufferAdd(&buf, xml, -1);
- VIR_FREE(xml);
}
+ virBufferAdjustIndent(&buf, -2);
virBufferAddLit(&buf, "</filter>\n");
if (virBufferError(&buf))
diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c
index 589fcf8..d189157 100644
--- a/src/conf/nwfilter_params.c
+++ b/src/conf/nwfilter_params.c
@@ -1,7 +1,7 @@
/*
* nwfilter_params.c: parsing and data maintenance of filter parameters
*
- * Copyright (C) 2011-2013 Red Hat, Inc.
+ * Copyright (C) 2011-2014 Red Hat, Inc.
* Copyright (C) 2010 IBM Corporation
*
* This library is free software; you can redistribute it and/or
@@ -907,6 +907,7 @@ virNWFilterFormatParamAttributes(virBufferPtr buf,
virBufferAsprintf(buf, "<filterref filter='%s'", filterref);
if (numKeys) {
virBufferAddLit(buf, ">\n");
+ virBufferAdjustIndent(buf, 2);
for (i = 0; i < numKeys; i++) {
const virNWFilterVarValue *value = items[i].value;
@@ -914,11 +915,12 @@ virNWFilterFormatParamAttributes(virBufferPtr buf,
for (j = 0; j < card; j++)
virBufferAsprintf(buf,
- " <parameter name='%s' value='%s'/>\n",
+ "<parameter name='%s' value='%s'/>\n",
(const char *)items[i].key,
virNWFilterVarValueGetNthValue(value, j));
}
+ virBufferAdjustIndent(buf, -2);
virBufferAddLit(buf, "</filterref>\n");
} else {
virBufferAddLit(buf, "/>\n");
--
1.8.5.3
More information about the libvir-list
mailing list