[libvirt] [PATCH] Fix locking in virsh console
Daniel P. Berrange
berrange at redhat.com
Mon Mar 10 11:11:04 UTC 2014
On Mon, Mar 10, 2014 at 03:04:15PM +0400, Roman Bogorodskiy wrote:
> vshRunConsole() uses virCondWait() which is a wrapper around
> pthread_cond_wait(). On FreeBSD, pthread_cond_wait needs mutex to be
> locked, otherwise it immediately fails with EPERM. On Linux, the
> behaviour in this case is undefined.
>
> So lock the mutex before calling virCondWait().
> ---
> tools/virsh-console.c | 5 +++++
> 1 file changed, 5 insertions(+)
ACK
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list