[libvirt] [PATCH 3/8] Make ebtablesForwardPolicyReject static

Daniel P. Berrange berrange at redhat.com
Mon Mar 10 13:29:13 UTC 2014


The ebtablesForwardPolicyReject method is only used internally
to the ebtables code and thus should have been static.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
---
 src/util/virebtables.c | 28 ++++++++++++++--------------
 src/util/virebtables.h |  3 ---
 2 files changed, 14 insertions(+), 17 deletions(-)

diff --git a/src/util/virebtables.c b/src/util/virebtables.c
index ce5e813..9848f50 100644
--- a/src/util/virebtables.c
+++ b/src/util/virebtables.c
@@ -381,20 +381,7 @@ ebtablesContextFree(ebtablesContext *ctx)
     VIR_FREE(ctx);
 }
 
-int
-ebtablesAddForwardPolicyReject(ebtablesContext *ctx)
-{
-    return ebtablesForwardPolicyReject(ctx, ADD);
-}
-
-
-int
-ebtablesRemoveForwardPolicyReject(ebtablesContext *ctx)
-{
-    return ebtablesForwardPolicyReject(ctx, REMOVE);
-}
-
-int
+static int
 ebtablesForwardPolicyReject(ebtablesContext *ctx,
                             int action)
 {
@@ -416,6 +403,19 @@ ebtablesForwardPolicyReject(ebtablesContext *ctx,
                                  NULL);
 }
 
+int
+ebtablesAddForwardPolicyReject(ebtablesContext *ctx)
+{
+    return ebtablesForwardPolicyReject(ctx, ADD);
+}
+
+
+int
+ebtablesRemoveForwardPolicyReject(ebtablesContext *ctx)
+{
+    return ebtablesForwardPolicyReject(ctx, REMOVE);
+}
+
 /*
  * Allow all traffic destined to the bridge, with a valid network address
  */
diff --git a/src/util/virebtables.h b/src/util/virebtables.h
index 91ef8b5..b0ca09f 100644
--- a/src/util/virebtables.h
+++ b/src/util/virebtables.h
@@ -61,7 +61,4 @@ int              ebtablesAddForwardPolicyReject(ebtablesContext *ctx);
 
 int              ebtablesRemoveForwardPolicyReject(ebtablesContext *ctx);
 
-int              ebtablesForwardPolicyReject(ebtablesContext *ctx,
-                                                  int action);
-
 #endif /* __QEMUD_ebtabLES_H__ */
-- 
1.8.5.3




More information about the libvir-list mailing list