[libvirt] [PATCH 0/8] Misc ebtables cleanup patches

Ján Tomko jtomko at redhat.com
Mon Mar 10 14:13:21 UTC 2014


On 03/10/2014 02:29 PM, Daniel P. Berrange wrote:
> In doing some work on the firewall code in libvirt I came across
> lots of cruft which could usefully be cleaned up..
> 
> Daniel P. Berrange (8):
>   Remove many decls from bridge driver platform header
>   Remove decl of method which doesn't exist in virebtables.h
>   Make ebtablesForwardPolicyReject static
>   Remove unused variables from ebtablesContext
>   Remove data structure holding list of ebtables rules
>   Remove worthless ebtRules data structure
>   Remove unused ebtablesRemoveForwardPolicyReject method
>   Remove broken error reporting in QEMU mac filtering
> 
>  src/Makefile.am                      |   4 +-
>  src/network/bridge_driver_linux.c    |  42 ++++---
>  src/network/bridge_driver_nop.c      |  42 -------
>  src/network/bridge_driver_platform.h |  22 ----
>  src/qemu/qemu_bridge_filter.c        | 104 ----------------
>  src/qemu/qemu_bridge_filter.h        |  37 ------
>  src/qemu/qemu_command.c              |  11 +-
>  src/qemu/qemu_conf.c                 |   1 -
>  src/qemu/qemu_driver.c               |   7 +-
>  src/qemu/qemu_hotplug.c              |  11 +-
>  src/qemu/qemu_process.c              |  10 +-
>  src/util/virebtables.c               | 233 +++--------------------------------
>  src/util/virebtables.h               |  24 ----
>  13 files changed, 60 insertions(+), 488 deletions(-)
>  delete mode 100644 src/qemu/qemu_bridge_filter.c
>  delete mode 100644 src/qemu/qemu_bridge_filter.h

ACK series

Jan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140310/52ff8a89/attachment-0001.sig>


More information about the libvir-list mailing list