[libvirt] [PATCH] BZ1072677: Avoid freeing of 0 file descriptor

Stefan Berger stefanb at us.ibm.com
Mon Mar 10 22:48:57 UTC 2014


Eric Blake <eblake at redhat.com> wrote on 03/10/2014 05:49:54 PM:


> 
> Indeed:
> 
> $ git grep memset.*1
> src/conf/domain_conf.c:    memset(max_idx, -1, sizeof(max_idx));
> src/qemu/qemu_command.c:        memset(tapfd, -1, tapfdSize *
> sizeof(tapfd[0]));
> src/qemu/qemu_command.c:        memset(vhostfd, -1, vhostfdSize *
> sizeof(vhostfd[0]));
> 
> So let's just copy that convention, instead of adding a new macro.
> 
> ACK to the qemu_hotplug fixes if you switch to raw memset.

Pushed.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140310/3dd858f5/attachment-0001.htm>


More information about the libvir-list mailing list