[libvirt] [java] Re: [PATCH 29/65] Implement equals and hashCode methods for Connect and Domain
Claudio Bley
cbley at av-test.de
Tue Mar 11 10:18:56 UTC 2014
At Fri, 21 Feb 2014 10:56:36 +0000,
Daniel P. Berrange wrote:
>
> This causes a violation of the hashCode API contract. Per the
> java api docs for java.lang.Object
Of course, right you're.
I've change the implementation of the hashCode methods accordingly
in order to take the URI and UUID into account. Please have a look at
the following patch.
As a future improvement, I think it would be feasible to cache
the URI and UUID per Connect and Domain instance, respectively.
Claudio Bley (1):
Implement equals and hashCode methods for Connect and Domain
src/main/java/org/libvirt/Connect.java | 39 +++++++++++++++++
src/main/java/org/libvirt/Domain.java | 52 ++++++++++++++++++++++-
src/test/java/org/libvirt/TestJavaBindings.java | 4 ++
3 files changed, 94 insertions(+), 1 deletion(-)
--
1.7.9.5
More information about the libvir-list
mailing list