[libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

[Daniel P. Berrange]

On Thu, Mar 06, 2014 at 09:35:47AM +0000, qiaonuohan at cn.fujitsu.com wrote:
> --memory-only option is introduced without compression supported. Therefore,
> this is a freature regression of virsh dump. Now qemu has support dumping memory
> in kdump-compressed format. This patch is adding new virDomainCoreDumpWithFormat
> API, so that the format in which qemu dump domain's memory can be specified.
> 

> +int
> +virDomainCoreDumpWithFormat(virDomainPtr domain, const char *to, unsigned int
> +                            dumpformat, unsigned int flags)
> +{
> +    virConnectPtr conn;
> +
> +    VIR_DOMAIN_DEBUG(domain, "to=%s, flags=%x", to, flags);
> +
> +    virResetLastError();
> +
> +    virCheckDomainReturn(domain, -1);
> +    conn = domain->conn;
> +
> +    virCheckReadOnlyGoto(conn->flags, error);
> +    virCheckNonNullArgGoto(to, error);
> +
> +    if (dumpformat >= VIR_DUMP_FORMAT_LAST) {
> +        virReportInvalidArg(flags, _("dumpformat '%d' is not supproted"),


s/supproted/supported/


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|