[libvirt] [PATCH 6/6] build: detect/prohibit hardcoded XML indent in syntax-check

Laine Stump laine at laine.org
Thu Mar 13 04:04:51 UTC 2014


This rule wouldn't be able to find any case of a hardcoded indent that
was in the middle of a string, but then virBuffer doesn't add
indentation in the middle of a string either.
---
 cfg.mk | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/cfg.mk b/cfg.mk
index 9ad8cf7..e83fa02 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -1,5 +1,5 @@
 # Customize Makefile.maint.                           -*- makefile -*-
-# Copyright (C) 2008-2013 Red Hat, Inc.
+# Copyright (C) 2008-2014 Red Hat, Inc.
 # Copyright (C) 2003-2008 Free Software Foundation, Inc.
 
 # This program is free software: you can redistribute it and/or modify
@@ -517,6 +517,11 @@ sc_prohibit_virBufferAsprintf_with_string_literal:
 	halt='use virBufferAddLit, not virBufferAsprintf, with a string literal' \
 	  $(_sc_search_regexp)
 
+sc_forbid_manual_xml_indent:
+	@prohibit='virBuffer.*" +<'			\
+	halt='use virBufferAdjustIndent instead of spaces when indenting xml'	\
+	  $(_sc_search_regexp)
+
 # Not only do they fail to deal well with ipv6, but the gethostby*
 # functions are also not thread-safe.
 sc_prohibit_gethostby:
-- 
1.8.5.3




More information about the libvir-list mailing list