[libvirt] [PATCH 2/6] virsh: eliminate hardcoded indentation in xml generated for commands

[Eric Blake]

On 03/12/2014 10:04 PM, Laine Stump wrote:
> These are never seen externally, only passed into libvirt APIs, so in
> practice this makes no real difference, but it's good to be
> consistent.
> ---
>  tools/virsh-domain.c   | 43 ++++++++++++++++++++++++-------------------
>  tools/virsh-pool.c     | 40 +++++++++++++++++++++++++---------------
>  tools/virsh-snapshot.c | 24 +++++++++++++++---------
>  tools/virsh-volume.c   | 26 ++++++++++++++++----------
>  4 files changed, 80 insertions(+), 53 deletions(-)

If nothing else, it keeps the new syntax check happy.

ACK.

>      if (source)
> -        virBufferAsprintf(&buf, "  <source %s='%s'/>\n",
> +        virBufferAsprintf(&buf, "<source %s='%s'/>\n",
>                            (isFile) ? "file" : "dev",

Wonder if it's worth dropping the extra () while you are here?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140313/ae72cc8e/attachment-0001.sig>