[libvirt] [PATCH 6/6] build: detect/prohibit hardcoded XML indent in syntax-check

[Eric Blake]

On 03/12/2014 10:04 PM, Laine Stump wrote:
> This rule wouldn't be able to find any case of a hardcoded indent that
> was in the middle of a string, but then virBuffer doesn't add
> indentation in the middle of a string either.
> ---
>  cfg.mk | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

ACK (but I'm biased, as I helped write it)

>  
> +sc_forbid_manual_xml_indent:
> +	@prohibit='virBuffer.*" +<'			\
> +	halt='use virBufferAdjustIndent instead of spaces when indenting xml'	\

Maybe line up the \ to a common column?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140313/cb42a140/attachment-0001.sig>