[libvirt] [PATCH] Introduce virFDStreamOpenPTY

Roman Bogorodskiy bogorodskiy at gmail.com
Sat Mar 15 10:25:09 UTC 2014


  Roman Bogorodskiy wrote:

> Add virFDStreamOpenPTY() function which is a wrapper around
> virFDStreamOpenFileInternal() with putting the device it opens into a
> raw mode.
> 
> Make virChrdevOpen() use virFDStreamOpenPTY() for
> VIR_DOMAIN_CHR_TYPE_PTY devices.
> 
> This fixes mangled console output when libvirt runs on FreeBSD as it
> requires device it opens to be placed into a raw mode explicitly.
> ---
>  src/conf/virchrdev.c |  2 +-
>  src/fdstream.c       | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  src/fdstream.h       |  5 +++++
>  3 files changed, 59 insertions(+), 1 deletion(-)

And I've just realised there's one more change that needs to be squashed
in for this:

diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index aaaac2f..7b181b5 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -797,6 +797,7 @@ virFDStreamConnectUNIX;
 virFDStreamCreateFile;
 virFDStreamOpen;
 virFDStreamOpenFile;
+virFDStreamOpenPTY;
 virFDStreamSetIOHelper;
 
Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140315/b28120ce/attachment-0001.sig>


More information about the libvir-list mailing list