[libvirt] [PATCH v6 1/4] add new virDomainCoreDumpWithFormat API

[Daniel P. Berrange]

On Sun, Mar 16, 2014 at 06:07:07AM +0000, qiaonuohan at cn.fujitsu.com wrote:
> --memory-only option is introduced without compression supported. Now qemu has
> support dumping domain's memory in kdump-compressed format. This patch is adding
> new virDomainCoreDumpWithFormat API, so that the format in which qemu dumps
> domain's memory can be specified.
> 
> Signed-off-by: Qiao Nuohan <qiaonuohan at cn.fujitsu.com>
> ---
>  include/libvirt/libvirt.h.in |  8 ++++
>  src/driver.h                 |  7 ++++
>  src/libvirt.c                | 92 ++++++++++++++++++++++++++++++++++++++++++++
>  src/libvirt_public.syms      |  5 +++
>  src/remote/remote_driver.c   |  1 +
>  src/remote/remote_protocol.x | 15 +++++++-
>  src/remote_protocol-structs  |  7 ++++
>  src/test/test_driver.c       | 21 ++++++++--
>  8 files changed, 152 insertions(+), 4 deletions(-)
> 
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 295d551..a0a8722 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -1731,6 +1731,14 @@ int                     virDomainCoreDump       (virDomainPtr domain,
>                                                   unsigned int flags);
>  
>  /*
> + * Domain core dump with format specified
> + */
> +int                 virDomainCoreDumpWithFormat (virDomainPtr domain,
> +                                                 const char *to,
> +                                                 const char *dumpformat,

NACK, please put this back as an enum as it was in previous versions.
This is exposing QEMU implementation names in the API which is bad.

> +                                                 unsigned int flags);

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|