[libvirt] [PATCH] Give virNWFilterVarCombIterNext saner semantics

Michal Privoznik mprivozn at redhat.com
Mon Mar 17 13:00:22 UTC 2014


On 17.03.2014 13:34, Daniel P. Berrange wrote:
> The virNWFilterVarCombIterNext method will free its
> parameter when it gets to the end of the iterator.
> This is somewhat misleading design, making it appear
> as if the caller has a memory leak. Remove the free'ing
> of the parameter and ensure that the calling method
> ebiptablesCreateRuleInstanceIterate free's it instead.
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>   src/conf/nwfilter_params.c                |  4 +---
>   src/nwfilter/nwfilter_ebiptables_driver.c | 12 ++++++------
>   2 files changed, 7 insertions(+), 9 deletions(-)
>

ACK

Michal




More information about the libvir-list mailing list