[libvirt] [PATCH] virlog: add log lock in virLogSetDefaultPriority
Daniel P. Berrange
berrange at redhat.com
Mon Mar 17 13:02:50 UTC 2014
On Mon, Mar 17, 2014 at 01:59:06PM +0100, Michal Privoznik wrote:
> On 17.03.2014 13:30, Wangrui (K) wrote:
> >When the global variable virLogDefaultPriority is modified, it will
> >
> >be better to have a lock.
> >
> >Signed-off-by: Zhou Yimin <zhouyimin at huawei.com>
> >
> >---
>
> Is there any specific behavior you are seeing? There's nothing wrong
> with the patch, but as far as I know Dan is trying to kill the log
> lock.
Adding this particular lock is ok. The situation should be harmless
though, since this function is only called in single-threaded
contexts I believe.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list