[libvirt] [PATCH] Add parameter to wait for lock in file locking APIs

Daniel P. Berrange berrange at redhat.com
Mon Mar 17 14:23:23 UTC 2014


On Mon, Mar 17, 2014 at 07:47:36PM +0530, Nehal J Wani wrote:
> Our current pidfile acquire APis (virPidFileAcquire) simply return -1 upon
> failure to acquire a lock. This patch adds a parameter 'bool waitForLock'
> which instructs the APIs if we want to make it block and wait for the lock
> or not.
> 
> ---
>  Based on Daniel's comments on:
>  https://www.redhat.com/archives/libvir-list/2014-March/msg00841.html
> 
>  daemon/libvirtd.c         |    2 +-
>  src/locking/lock_daemon.c |    4 ++--
>  src/util/virfile.c        |   14 +++++++++-----
>  src/util/virfile.h        |    2 +-
>  src/util/virlockspace.c   |    6 +++---
>  src/util/virpidfile.c     |    6 ++++--
>  src/util/virpidfile.h     |    2 ++
>  7 files changed, 22 insertions(+), 14 deletions(-)

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list