[libvirt] [PATCH 4/7] Don't leave empty first line in C source files
Eric Blake
eblake at redhat.com
Mon Mar 17 15:27:14 UTC 2014
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
> If there should be some sort of separator it is better to use comment
> with the filename, copyright, description, license information and
> authors.
>
> Found by:
>
> git grep -nH '^$' | grep '\.[ch]:1:'
>
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>
> Notes:
> If any reviewer wants I can add a syntax-check for that.
Yes, that would be a nice followup. We already have a check for
trailing blank lines; can that check be extended to also cover leading
blank lines?
> +++ b/tests/xml2sexprtest.c
> @@ -1,4 +1,3 @@
> -
> #include <config.h>
>
ACK
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140317/fb089e11/attachment-0001.sig>
More information about the libvir-list
mailing list