[libvirt] [PATCH] Enforce attribute check of the virRegister functions

[Pavel Hrdina]

On 17.3.2014 17:47, Daniel P. Berrange wrote:
> On Mon, Mar 17, 2014 at 05:33:58PM +0100, Pavel Hrdina wrote:
>> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>> ---
>>   src/driver.h | 16 ++++++++--------
>>   1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/src/driver.h b/src/driver.h
>> index fbfaac4..d106d59 100644
>> --- a/src/driver.h
>> +++ b/src/driver.h
>> @@ -2132,15 +2132,15 @@ struct _virNWFilterDriver {
>>    * TODO: also need ways to (des)activate a given driver
>>    *       lookup based on the URI given in a virConnectOpen(ReadOnly)
>>    */
>> -int virRegisterDriver(virDriverPtr);
>> -int virRegisterNetworkDriver(virNetworkDriverPtr);
>> -int virRegisterInterfaceDriver(virInterfaceDriverPtr);
>> -int virRegisterStorageDriver(virStorageDriverPtr);
>> -int virRegisterNodeDeviceDriver(virNodeDeviceDriverPtr);
>> -int virRegisterSecretDriver(virSecretDriverPtr);
>> -int virRegisterNWFilterDriver(virNWFilterDriverPtr);
>> +int virRegisterDriver(virDriverPtr) ATTRIBUTE_RETURN_CHECK;
>> +int virRegisterNetworkDriver(virNetworkDriverPtr) ATTRIBUTE_RETURN_CHECK;
>> +int virRegisterInterfaceDriver(virInterfaceDriverPtr) ATTRIBUTE_RETURN_CHECK;
>> +int virRegisterStorageDriver(virStorageDriverPtr) ATTRIBUTE_RETURN_CHECK;
>> +int virRegisterNodeDeviceDriver(virNodeDeviceDriverPtr) ATTRIBUTE_RETURN_CHECK;
>> +int virRegisterSecretDriver(virSecretDriverPtr) ATTRIBUTE_RETURN_CHECK;
>> +int virRegisterNWFilterDriver(virNWFilterDriverPtr) ATTRIBUTE_RETURN_CHECK;
>>   # ifdef WITH_LIBVIRTD
>> -int virRegisterStateDriver(virStateDriverPtr);
>> +int virRegisterStateDriver(virStateDriverPtr) ATTRIBUTE_RETURN_CHECK;
>>   # endif
>>   void virDriverModuleInitialize(const char *defmoddir);
>>   void *virDriverLoadModule(const char *name);
>
> ACK
>
> Regards,
> Daniel
>

Thanks, pushed.

Pavel