[libvirt] [PATCH] bhyve: allow to destroy only active domains

Roman Bogorodskiy bogorodskiy at gmail.com
Mon Mar 17 17:29:44 UTC 2014


  Daniel P. Berrange wrote:

> On Sat, Mar 15, 2014 at 07:49:14PM +0400, Roman Bogorodskiy wrote:
> > Add a check that domain is active before attempting to destroy it.
> > ---
> >  src/bhyve/bhyve_driver.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
> > index 9dbb299..60d49de 100644
> > --- a/src/bhyve/bhyve_driver.c
> > +++ b/src/bhyve/bhyve_driver.c
> > @@ -567,6 +567,12 @@ bhyveDomainDestroy(virDomainPtr dom)
> >      if (virDomainDestroyEnsureACL(dom->conn, vm->def) < 0)
> >          goto cleanup;
> >  
> > +    if (!virDomainObjIsActive(vm)) {
> > +        virReportError(VIR_ERR_OPERATION_INVALID,
> > +                       "%s", _("Domain is not running"));
> > +        goto cleanup;
> > +    }
> > +
> >      ret = virBhyveProcessStop(privconn, vm, VIR_DOMAIN_SHUTOFF_DESTROYED);
> 
> ACK

Pushed, thanks!

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140317/fb904675/attachment-0001.sig>


More information about the libvir-list mailing list