[libvirt] [PATCH] virNetServerNewPostExecRestart: Initialize @max_anonymous_clients

Daniel P. Berrange berrange at redhat.com
Tue Mar 18 10:17:14 UTC 2014


On Tue, Mar 18, 2014 at 11:10:58AM +0100, Michal Privoznik wrote:
> Coverity spotted a use of possibly undefined variable. If a server is
> restarting as an result of update, the JSON file that keeps current
> value of some variables will not contain the new variables. This is
> the case of @max_anonymous_clients too. We are correctly querying if
> there's "max_anonymous_clients" in the JSON, however, we are not
> setting a sane default if there's none.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/rpc/virnetserver.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)

ACK

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list