[libvirt] [PATCH 5/6] Change 'int isTempChain' to bool in nwfilter

Eric Blake eblake at redhat.com
Tue Mar 18 15:21:14 UTC 2014


On 03/18/2014 07:36 AM, Daniel P. Berrange wrote:
> The 'int isTempChain' parameter to various nwfilter methods
> only takes two values so should be a bool type.
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  src/nwfilter/nwfilter_ebiptables_driver.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 

This touches a lot of the same lines as 1/6 when you changed incoming to
bool.  Should you squash the two patches to minimize the churn?

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140318/fc1622fe/attachment-0001.sig>


More information about the libvir-list mailing list