[libvirt] [PATCH] qemuDomainSetInterfaceParameters: Allow bandwidth clear out

[Eric Blake]

On 03/18/2014 04:01 AM, Michal Privoznik wrote:
> We allow translation from no_bandwidth to has_bandwidth for a vnic.
> However, going in the opposite direction is not implemented. It's not
> limitation of the API rather than internal implementation.

Awkward.  How about:

It's not a limitation of the API, rather a missing part of the internal
implementation.

> The problem
> is, we correctly detect that user hasn't specified any outbound (say
> he wants to clear out outbound). However, this gets overwritten by
> current vnic outbound settings. Then, virNetDevBandwidthSet doesn't
> change anything. We need to stop overwriting the outbound if users
> don't want us to. Same applies for inbound.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_driver.c | 15 +++++++++++----
>  tools/virsh-domain.c   |  4 ++--
>  tools/virsh.pod        |  3 +++
>  3 files changed, 16 insertions(+), 6 deletions(-)
> 

>  
> +To clear inbound or outbound settings, use I<--inbound> or I<--outbound>
> +respectfully with average of value zero.

s/of value/value of/

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140318/8165f400/attachment-0001.sig>