[libvirt] [PATCH v2] nwfilter: Fix double free of pointer

Daniel P. Berrange berrange at redhat.com
Wed Mar 19 17:24:52 UTC 2014


On Wed, Mar 19, 2014 at 11:47:09AM -0400, Stefan Berger wrote:
> From: Stefan Berger <stefanb at linux.vnet.ibm.com>
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1071181
> 
> Commit 49b59a15 fixed one problem but masks another one related to pointer
> freeing.
> 
> Avoid putting of the virNWFilterSnoopReq once the thread has been started.
> It belongs to the thread and the thread will call virNWFilterSnoopReqPut() on it.
> 
> Signed-off-by: Stefan Berger <stefanb at linux.vnet.ibm.com>
> ---
>  src/nwfilter/nwfilter_dhcpsnoop.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list