[libvirt] [PATCH python] override: GetCPUModelNames should return None on failure
Cole Robinson
crobinso at redhat.com
Thu Mar 20 17:53:52 UTC 2014
On 03/20/2014 01:52 PM, Eric Blake wrote:
> On 03/20/2014 11:28 AM, Cole Robinson wrote:
>> Right now, on failure, libvirt.py doesn't raise an exception and just
>> returns -1 to the user.
>> ---
>> libvirt-override.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libvirt-override.c b/libvirt-override.c
>> index 7f746ed..9fed299 100644
>> --- a/libvirt-override.c
>> +++ b/libvirt-override.c
>> @@ -2326,7 +2326,7 @@ libvirt_virConnectGetCPUModelNames(PyObject *self ATTRIBUTE_UNUSED,
>> LIBVIRT_END_ALLOW_THREADS;
>>
>> if (c_retval == -1)
>> - return VIR_PY_INT_FAIL;
>> + return VIR_PY_NONE;
>>
>
> Incomplete. The error: label needs the same treatment.
>
> ACK with that fix.
>
Good catch. Fixed and pushed
- Cole
More information about the libvir-list
mailing list