[libvirt] [PATCH] qemu: Return meaningful error when qemu dies early

[Jiri Denemark]

On Thu, Mar 20, 2014 at 15:51:44 +0100, Michal Privoznik wrote:
> On 17.03.2014 13:21, Jiri Denemark wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=844378
> >
> > When qemu dies early after connecting to its monitor but before we
> > actually try to read something from the monitor, we would just fail
> > domain start with useless message:
> >
> >      "An error occurred, but the cause is unknown"
> >
> > This is because the real error gets reported in a monitor EOF handler
> > executing within libvirt's event loop.
> >
> > The fix is to take any error set in qemuMonitor structure and propagate
> > it into the thread-local error when qemuMonitorClose is called and no
> > thread-local error is set.
> >
> > Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> > ---
> >   src/qemu/qemu_monitor.c | 6 ++++++
> >   1 file changed, 6 insertions(+)
> 
> ACK

Pushed, thanks.

Jirka