[libvirt] [PATCH] tests: Set abs_*dir in a consistent way
Jiri Denemark
jdenemar at redhat.com
Thu Mar 20 21:59:36 UTC 2014
On Thu, Mar 20, 2014 at 15:01:35 -0600, Eric Blake wrote:
> On 03/19/2014 07:50 AM, Jiri Denemark wrote:
> > Use $(shell cd $(...) && pwd) to set abs_*dir variables similarly to
> > what src/Makefile.am does.
> >
> > Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> > ---
> > tests/Makefile.am | 16 ++++++++++------
> > 1 file changed, 10 insertions(+), 6 deletions(-)
>
> > AM_CFLAGS = \
> > - -Dabs_builddir="\"`pwd`\"" \
> > - -Dabs_srcdir="\"`cd '$(srcdir)'; pwd`\"" \
> > + -Dabs_builddir="\"$(abs_builddir)\"" \
> > + -Dabs_srcdir="\"$(abs_srcdir)\"" \
>
> A little shorter as -Dabs_builddir='"$(abs_builddir)"', but works as-is.
>
> >
> > -lv_abs_top_builddir=`cd '$(top_builddir)'; pwd`
> > +lv_abs_top_builddir=$(shell cd '$(top_builddir)'; pwd)
>
> While touching this, s/;/&&/ to match the abs_srcdir setting.
>
> ACK with that tweak.
Fixed and pushed, thanks.
Jirka
More information about the libvir-list
mailing list