[libvirt] [libvirt-python PATCH] setup: Make libvirt API XML path configurable

[Eric Blake]

On 03/13/2014 12:03 AM, Martin Kletzander wrote:
> On Wed, Mar 12, 2014 at 11:15:43AM -0600, Eric Blake wrote:
>> Revisiting an older thread
>>

>>>>> -        libvirt_api = get_pkgconfig_data(["--variable", "libvirt_api"], "libvirt")
>>>>> +        libvirt_api = os.getenv("LIBVIRT_API_PATH")
>>>>> +
>>
>>>>
>>>> NACK, setting pkg-config already takes care of this. See the
>>>> build-many.sh scrpit attached to this mail which demonstrates
>>>> use of PKG_CONFIG_PATH to build against every version of libvirt
>>>> back to 0.9.11

Is there a way to point pkg-config at an in-tree uninstalled libvirt?

> 
> I'd be still happy to have this in, especially for us developers.
> It's useful when testing a libvirt-python patch against upstream
> libvirt which, in this case, doesn't have to be installed to make the
> bindings work.

I played more with it today, and it is not quite enough.
LIBVIRT_API_PATH=/path/to/libvirt/src/libvirt-api.xml picks up the
in-tree API additions, but still compiles against installed libvirt.h.
Which means that if you have added a new API (such as my recent qemu
monitor registration), the build correctly warned me if I didn't use
LIBVIR_CHECK_VERSION(1,2,3) to protect things, but when I _do_ properly
guard things, I'm not actually compile-testing the new code because the
installed libvirt.h is from an older vintage.  If we are going to do an
override (whether by some pkg-config override or by your env-var
proposal), then it needs to catch EVERYTHING from the uninstalled tree
(both libvirt-api.xml AND libvirt.h).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140321/46fcdbbf/attachment-0001.sig>