[libvirt] [PATCH] bhyve: add domainCreateWithFlags support

Roman Bogorodskiy bogorodskiy at gmail.com
Sun Mar 23 08:15:22 UTC 2014


  Michal Privoznik wrote:

> If this fails, we should kill the domain and return an error. It won't happen currently, as ret is equal to zero in this area of code (it's not visible in the context, but this whole block starts with 'if (ret == 0) {'). Moreover, the same bug is present a few line above, just at the beginning of the block. So the code I'm aiming at looks like this:

Thanks for noticing that!

> ACK with that squashed in.

Pushed, thanks for the review,

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140323/a3c95a02/attachment-0001.sig>


More information about the libvir-list mailing list