[libvirt] [PATCH] qemuDomainGetImageIds: Skip <seclabel/> without label

[Eric Blake]

On 03/24/2014 10:16 AM, Michal Privoznik wrote:
> It's easy to shed the daemon these days. With this XML snippet:
> 
>     <disk type='file' device='disk'>
>       <driver name='qemu' type='raw'/>
>       <source file='/some/dummy/path/test.bin'>
>         <seclabel model='dac' relabel='no'/>
>       </source>
>       <target dev='vdb' bus='virtio'/>
>       <readonly/>
>       <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
>     </disk>
> 
> I get the SIGSEGV when starting the domain. The thing is, when
> starting a domain, we check for its disk presence. For some reason,
> when determining the disk chain, we parse the <seclabel/> (don't ask
> me why). However, there's no label attribute in the XML, so we end up
> calling virParseOwnershipIds() over NULL string:

> ---
>  src/qemu/qemu_domain.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140324/2318243b/attachment-0001.sig>