[libvirt] [PATCH] util: Sanitize ATTRIBUTE_NONNULL use in viriscsi.h

Ján Tomko jtomko at redhat.com
Tue Mar 25 07:32:04 UTC 2014


On 03/25/2014 08:23 AM, Peter Krempa wrote:
> Some of the function attributes marked as nonnull actually explicitly
> handle the arguments for NULL. All changed functions handle missing
> "initiatoriqn" argument well and virISCSIScanTargets also handles well
> if the return pointers are missing. Remove some of the liberaly used
> ATTRIBUTE_NONNULLs as coverity and possibly other compilers that honor
> the attribute fail to compile the code.
> 
> Flaw introduced in commit 5e1d5dde
> ---
>  src/util/viriscsi.h | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

ACK

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140325/a5dc7005/attachment-0001.sig>


More information about the libvir-list mailing list