[libvirt] [PATCHv2 1/6] Add utility functions for storing uninstalled location

[Daniel P. Berrange]

On Tue, Mar 25, 2014 at 01:53:11PM +0530, Nehal J Wani wrote:
> src/libvirt_private.syms
>    *Add symbols
> 
> daemon/libvirtd.c
>    *Set uninstallDir when libvirtd is running uninstalled
>     from a build tree
> 
> src/util/virutil.c
>    *Introduce virSetUninstalledDir
>    *Introduce virGetUninstalledDir
> 
> ---
>  daemon/libvirtd.c        |    1 +
>  src/libvirt_private.syms |    2 ++
>  src/util/virutil.c       |   27 +++++++++++++++++++++++++++
>  src/util/virutil.h       |    3 +++
>  4 files changed, 33 insertions(+), 0 deletions(-)
> 
> diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
> index 4179147..dc3da2a 100644
> --- a/daemon/libvirtd.c
> +++ b/daemon/libvirtd.c
> @@ -1165,6 +1165,7 @@ int main(int argc, char **argv) {
>              exit(EXIT_FAILURE);
>          }
>          *tmp = '\0';
> +        virSetUninstalledDir(argv[0]);

argv[0] is not a directory - it is the path to the libvirtd
file. Either this is a mistake, or this is a very misleading
function name.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|