[libvirt] [PATCH 24/24] Add a rule for indenting labels

Ján Tomko jtomko at redhat.com
Tue Mar 25 14:53:44 UTC 2014


On 03/25/2014 02:40 PM, Martin Kletzander wrote:
> On Tue, Mar 25, 2014 at 08:04:08AM +0100, Ján Tomko wrote:
>> diff --git a/cfg.mk b/cfg.mk
>> index 559f719..cbcf40b 100644
>> --- a/cfg.mk
>> +++ b/cfg.mk
>> @@ -898,6 +898,12 @@ sc_prohibit_virConnectOpen_in_virsh:
>>  	halt='Use vshConnect() in virsh instead of virConnectOpen*'    \
>>  	  $(_sc_search_regexp)
>>  
>> +sc_require_space_before_label:
>> +	@prohibit='^[_a-zA-Z0-9]+:$$'                                  \
> 
> Couldn't we at least prohibit 2 and 3 spaces as well?  I mean doing:
> 
> prohibit='^(   ?)?[_a-zA-Z0-9]+:$$'
> 
> ACK with that amended.
> 

I've changed the regexp and pushed the series.

Thanks for the reviews!

Jan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140325/222437cc/attachment-0001.sig>


More information about the libvir-list mailing list