[libvirt] [PATCH] libvirt-tck: 052-domain-hook.t - reload after hook cleanup
Mike Latimer
mlatimer at suse.com
Tue Mar 25 20:49:37 UTC 2014
I just realized this was never reviewed/commented on. Without this patch,
libvirtd is left in a state where future tests expect hooks to exist, but the
hooks themselves are removed in $hook->cleanup. The subsequent 'hook files not
found' errors cause the tests to fail.
-Mike
On Thursday, March 06, 2014 03:41:01 PM Mike Latimer wrote:
> Reload libvirtd after hook testing has completed. Otherwise, libvirtd
> is still expecting hook test scripts to exist.
>
> ---
> scripts/hooks/052-domain-hook.t | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/scripts/hooks/052-domain-hook.t
> b/scripts/hooks/052-domain-hook.t index 90b8a48..d1070b5 100644
> --- a/scripts/hooks/052-domain-hook.t
> +++ b/scripts/hooks/052-domain-hook.t
> @@ -180,4 +180,8 @@ SKIP: {
> Sys::Virt::Error::ERR_NO_DOMAIN);
>
> $hook->cleanup();
> +
> + diag "reload libvirtd after hook cleanup";
> + $hook->action('reload');
> + $hook->service_libvirtd();
> };
More information about the libvir-list
mailing list