[libvirt] [PATCH 0/3] Resolve recent/new Coverity warnings
John Ferlan
jferlan at redhat.com
Tue Mar 25 21:25:30 UTC 2014
On 03/25/2014 02:00 PM, John Ferlan wrote:
> For virlog.c and commandtest.c - it seems recent changes within the
> modules have allowed Coverity to dig deeper and find different issues.
> Not sure why Coverity has that "ability"... Since I was making changes,
> figured I'd clean up the lxc_controller fd leak as well - these should
> clean the Jenkins build environment.
>
> John Ferlan (3):
> Coverity: Resolve a CHECKED_RETURN message
> Coverity: Resolve a FORWARD_NULL
> Coverity: Resolve a RESOURCE_LEAK
>
> src/lxc/lxc_controller.c | 14 ++++++++++----
> src/util/virlog.c | 2 +-
> tests/commandtest.c | 1 +
> 3 files changed, 12 insertions(+), 5 deletions(-)
>
Pushed
I did change 3/3 to use (ret < 0), my brain was just copying what it saw
in virFileLoopDeviceAssociate()
Tks,
John
More information about the libvir-list
mailing list