[libvirt] [PATCH 1/2] Add close listener types

[Claudio Bley]

At Wed, 26 Mar 2014 02:43:48 +0000,
Chris Ellis wrote:
> 
> ---
>  src/main/java/org/libvirt/event/ConnectionCloseListener.java | 9 +++++++++
>  src/main/java/org/libvirt/event/ConnectionCloseReason.java   | 8 ++++++++

You're right, those files were missing because I forgot to 'git add'
them before submitting my patchset. But, why didn't you just say so
as you reviewed the patches?

NACK, since I already have those files in my local branch including
javadoc comments, with short names for the enum constants and the
usual "UNKNOWN" constant.

Here's what I squashed into patch 49/65 of the series:

----------- >8 ----------------- 8< ----------------------------------
diff --git a/src/main/java/org/libvirt/event/ConnectionCloseListener.java b/src/main/java/org/libvirt/event/ConnectionCloseListener.java
new file mode 100644
index 0000000..4845b53
--- /dev/null
+++ b/src/main/java/org/libvirt/event/ConnectionCloseListener.java
@@ -0,0 +1,10 @@
+package org.libvirt.event;
+
+import org.libvirt.Connect;
+
+/**
+ * Interface for receiving events when a connection is closed.
+ */
+public interface ConnectionCloseListener {
+    void onClose(Connect conn, ConnectionCloseReason reason);
+}
diff --git a/src/main/java/org/libvirt/event/ConnectionCloseReason.java b/src/main/java/org/libvirt/event/ConnectionCloseReason.java
new file mode 100644
index 0000000..0dd2924
--- /dev/null
+++ b/src/main/java/org/libvirt/event/ConnectionCloseReason.java
@@ -0,0 +1,17 @@
+package org.libvirt.event;
+
+public enum ConnectionCloseReason {
+    /** Misc I/O error */
+    ERROR,
+
+    /** End-of-file from server */
+    EOF,
+
+    /** Keepalive timer triggered */
+    KEEPALIVE,
+
+    /** Client requested it */
+    CLIENT,
+
+    UNKNOWN
+}
-- 
BSc (Comp) Claudio Bley - Principal Software Engineer
AV-TEST GmbH, Klewitzstr. 7, 39112 Magdeburg, Germany
Phone: +49 391 6075460, Fax: +49 391 6075469
Web: <http://www.av-test.org>

* https://twitter.com/avtestorg * https://facebook.com/avtestorg *
* https://plus.google.com/100383867141221115206/ *

Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076)
Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern

Our services shall be effected on the basis of the General Terms
and Conditions of AV-TEST GmbH, which are accessible under
<http://www.av-test.org/en/av-test/terms-and-conditions/> or
obtainable upon request.

Unsere Leistungen erfolgen auf der Grundlage der Allgemeinen
Geschäftsbedingungen der AV-TEST GmbH, die unter
<http://www.av-test.org/av-test/agb/> abrufbar sind oder auf
Anfrage übersandt werden.