[libvirt] [PATCH v2] dnsmasq: allowing RFC 2782 compliant SRV records

[Laine Stump]

On 03/08/2014 01:13 AM, Steven Malin wrote:
> This patch allows RFC 2782 compliant SRV records in the network
> config and corrects the documentation.

Thanks for bringing this bug to light in such a proactive way (with a
patch rather than just a complaint :-)). Your patch pointed out that the
SRV records produced by libvirt were totally unusable (since any
application will be looking for _service._protocol.example.com, but
libvirt was unable to produce any such records).

Rather than allowing libvirt to optionally create usable SRV records
though, I made a different patch that *forces* it to create usable
records, while fixing some other bugs that I found along the way:

  https://www.redhat.com/archives/libvir-list/2014-March/msg01206.html

I just pushed that patch upstream (commit
6612d1adb7943daf05feec002d7a025263c84a4f). Please give it a try and see
if it solves your problems.

Note that once this patch is applied, you will *not* want to put the
leading "_" in either the service or protocol name in the configuration.
(This would have created a backward compatibility problem, except that
the old code couldn't have been usable by anyone anyway).