[libvirt] [RFC PATCH] Behaviour of topology, vcpus and maxcpus

[Nikunj A Dadhania]

Nikunj A Dadhania <nikunj at linux.vnet.ibm.com> writes:

> I have observed the following with libvirt xml:
>
> <vcpu>6</vcpu>
> <cpu>
>   <topology sockets='1' cores='4' threads='2'/>
> </cpu>
>
> So according to the topology maximum supported is 8 vcpus, while the
> libvirt sets that to 6 - specified in <vcpu> tag. Shouldn't libvirt
> error this out as the mismatch between the topology definition and the
> vcpu count?
>
> There is an upper bound check already in place where if we have maxcpu >
> topology-supported cpus, that errors out. For eg.
>
> <vcpu>12</vcpu>
> <cpu>
>   <topology sockets='1' cores='4' threads='2'/>
> </cpu>
>
> The below patch make sures that libvirt does the lower bound check as
> well.
>
Ping, Any comments?

Regards
Nikunj