[libvirt] [PATCH] Expose SLIRP attributes

[Daniel P. Berrange]

On Thu, Mar 27, 2014 at 11:55:45AM -0600, Eric Blake wrote:
> On 03/27/2014 11:17 AM, Michal Privoznik wrote:
> > We allow users to use SLIRP stack. However, there are some knobs
> > which are not exposed to users, such as host network address, DNS
> > server, smb, and others.
> > 
> > Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> > ---
> >  docs/formatdomain.html.in                          |  7 +-
> >  docs/schemas/domaincommon.rng                      | 23 +++++-
> >  src/conf/domain_conf.c                             | 88 ++++++++++++++++++++++
> >  src/conf/domain_conf.h                             |  6 ++
> >  src/qemu/qemu_command.c                            | 19 +++++
> >  .../qemuxml2argvdata/qemuxml2argv-net-user-ip.args |  7 ++
> >  .../qemuxml2argvdata/qemuxml2argv-net-user-ip.xml  | 33 ++++++++
> >  tests/qemuxml2argvtest.c                           |  1 +
> >  8 files changed, 180 insertions(+), 4 deletions(-)
> >  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-net-user-ip.args
> >  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-net-user-ip.xml
> > 
> > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> > index 7f90455..0a353ca 100644
> > --- a/docs/formatdomain.html.in
> > +++ b/docs/formatdomain.html.in
> > @@ -3225,7 +3225,11 @@
> >        starting from <code>10.0.2.15</code>. The default router will be
> >        <code>10.0.2.2</code> and the DNS server will be <code>10.0.2.3</code>.
> >        This networking is the only option for unprivileged users who need their
> > -      VMs to have outgoing access.
> > +      VMs to have outgoing access. <span class="since">Since 1.2.3</span> the
> 
> We've already frozen for 1.2.3, and this feels like new features rather
> than bug fix.  Is it better to wait until after the release?

Given the ongoing comments, I think 1.2.4 is most suitable at this time.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|