[libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

[Mike Latimer]

On Friday, March 28, 2014 12:26:26 PM Daniel P. Berrange wrote:
> A bunch of tests currently attempt to kickstart a full Fedora
> OS image install. Everytime I try to update this kickstart to
> a new version of Fedora it causes no end of pain. Switch the
> tests over to use Richard Jones' virt-builder command which
> is part of libguestfs. This makes it trivial to deploy and
> customize full OS images from pre-built templates.
> 
> Mike - does Suse include a new enough version of libguestfs
> to get access to the 'virt-builder' tool yet ?
> 
> Daniel P. Berrange (6):
>   Add ability to provision full OS using virt-builder
>   Fix path to dnsmasq leases file
>   Add ability to setup NIC when creating guest XML
>   Force destroy guests if graceful shutdown fails
>   Convert nwfilter and domain balloon tests to virtbuilder images
>   Remove obsolete kickstart provisioning helper methods
> 
>  Build.PL                                  |   1 -
>  conf/default.cfg                          |  25 +++
>  conf/ks.cfg                               |  30 ----
>  lib/Sys/Virt/TCK.pm                       | 280
> +++++++++++++++++++++++++----- lib/Sys/Virt/TCK/DomainBuilder.pm         | 
> 20 ++-
>  lib/Sys/Virt/TCK/NetworkHelpers.pm        | 140 +--------------
>  perl-Sys-Virt-TCK.spec.PL                 |   1 -
>  scripts/domain/110-memory-balloon.t       |  10 +-
>  scripts/nwfilter/090-install-image.t      |  55 ------
>  scripts/nwfilter/100-ping-still-working.t |  54 +++---
>  scripts/nwfilter/210-no-mac-spoofing.t    |  81 +++++----
>  scripts/nwfilter/220-no-ip-spoofing.t     |  78 +++++----
>  scripts/nwfilter/230-no-mac-broadcast.t   |  53 +++---
>  scripts/nwfilter/240-no-arp-spoofing.t    |  60 ++++---
>  scripts/nwfilter/300-vsitype.t            |  40 +++--
>  scripts/nwfilter/nwfilter_concurrent.sh   |   4 +-
>  16 files changed, 493 insertions(+), 439 deletions(-)
>  delete mode 100644 conf/ks.cfg
>  delete mode 100644 scripts/nwfilter/090-install-image.t

ACK to all of this. For some reason, Fedora 20 didn't want to install for me 
(it failed when resizing the disk, and I don't have time to chase it today), 
but Fedora 19 did. Looks like there are no SUSE images in virt-builder, so 
I'll work on adding those later.

I have a minor patch I'll submit next that will just allow me to drop one more 
local patch. If you don't want to worry about distros with older (or no) 
versions of libguestfs, then this patch series looks ready to go.

-Mike