[libvirt] [PATCH 2/6] storage: netfs: Split up and tidy up NFS storage pool source function

Eric Blake eblake at redhat.com
Fri Mar 28 22:13:02 UTC 2014


On 03/28/2014 04:01 PM, Peter Krempa wrote:
> Extract the NFS related stuff into a separate function and tidy up the
> rest of the code so we can reuse it to add gluster backend detection.
> 
> Additionally avoid reporting of errors from "showmount" and return an
> empty source list instead. This will help when adding other detection
> backends.
> ---
>  src/storage/storage_backend_fs.c | 53 +++++++++++++++++++++++-----------------
>  1 file changed, 31 insertions(+), 22 deletions(-)

Mostly mechanical, but it's borderline (used by patch 4/6, which feels
more like a feature than bug fix) and big enough that I'd feel better
waiting for 1.2.4 before pushing this one.  But once that happens,

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140328/aebd918f/attachment-0001.sig>


More information about the libvir-list mailing list