[libvirt] [PATCH 4/6] storage: gluster: Implement storage pool lookup

Eric Blake eblake at redhat.com
Fri Mar 28 22:22:40 UTC 2014


On 03/28/2014 04:01 PM, Peter Krempa wrote:
> Use the previously implemented function to lookup glusterfs source pools
> for the netfs pool to lookup native gluster pools too.
> ---
>  src/storage/storage_backend_gluster.c | 50 +++++++++++++++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 

> +
> +    if (!srcSpec) {
> +        virReportError(VIR_ERR_INVALID_ARG, "%s",
> +                       _("hostname must be specified for gluster sources"));

Would it make sense to check localhost if srcSpec is NULL?

Again, post-1.2.3, but looks reasonable.  ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140328/5407a316/attachment-0001.sig>


More information about the libvir-list mailing list