[libvirt] [PATCH 14/n] conf: move volume structs to util/

Peter Krempa pkrempa at redhat.com
Mon Mar 31 09:57:35 UTC 2014


On 03/30/14 05:37, Eric Blake wrote:
> Another step towards unification of structures.  While we might
> not expose everything in XML via domain disk as we do for
> storage volume pointer, both places want to deal with (at least
> part of) the backing chain; therefore, moving towards a single
> struct usable from both contexts will make the backing chain
> code more reusable.
> 
> * src/conf/storage_conf.h (_virStoragePerms)
> (virStorageTimestamps): Move...
> * src/util/virstoragefile.h: ...here.
> (_virStorageSource): Add more fields.
> * src/util/virstoragefile.c (virStorageSourceClear): Clean
> additional fields.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/conf/storage_conf.h   | 23 +----------------------
>  src/util/virstoragefile.c |  6 ++++++
>  src/util/virstoragefile.h | 26 ++++++++++++++++++++++++++
>  3 files changed, 33 insertions(+), 22 deletions(-)
> 

I don't like the mixing in of storage volume target from the storage
drivers ... see 15/n for my reasoning.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140331/2408d66d/attachment-0001.sig>


More information about the libvir-list mailing list