[libvirt] [PATCH 0/6] eliminate hardcoded indent from all XML - PART 2

Laine Stump laine at laine.org
Thu Mar 13 04:04:45 UTC 2014


This is a followup to 

  https://www.redhat.com/archives/libvir-list/2014-March/msg00350.html

Eric had ACKed all of those patches, but pointed out some
omissions. The first patch of this series should be squashed into 1/9
of the previous series (which I haven't yet pushed), and the others
are new. The final patch adds a syntax-check rule to keep new
hardcoded spacing from creeping in. (I'm still pondering the idea of
giving virBuffer a "pretty print" mode. It would certainly make it
more difficult to mess up indentation).

Laine Stump (6):
  squash this into domain conf XML "eliminate hardcoded indent" patch
  virsh: eliminate hardcoded indentation in xml generated for commands
  qemu: eliminate hardcoded indent from migration cookie xml
  util: eliminate hardcoded indent in virConnectSysInfo formatting
  qemu: elmininate hardcoded indent in capabilities cache XML
  build: detect/prohibit hardcoded XML indent in syntax-check

 cfg.mk                       |  7 ++++-
 src/conf/domain_conf.c       |  2 +-
 src/lxc/lxc_domain.c         |  4 +--
 src/qemu/qemu_capabilities.c | 20 ++++++------
 src/qemu/qemu_domain.c       | 45 ++++++++++++++++-----------
 src/qemu/qemu_migration.c    | 49 ++++++++++++++++++------------
 src/util/virsysinfo.c        | 72 ++++++++++++++++++++++++--------------------
 tools/virsh-domain.c         | 43 ++++++++++++++------------
 tools/virsh-pool.c           | 40 +++++++++++++++---------
 tools/virsh-snapshot.c       | 24 +++++++++------
 tools/virsh-volume.c         | 26 ++++++++++------
 11 files changed, 196 insertions(+), 136 deletions(-)

-- 
1.8.5.3




More information about the libvir-list mailing list