[libvirt] [PATCH] php: implement libvirt_node_get_free_memory.

[Eric Blake]

On 05/01/2014 01:05 PM, Dawid Zamirski wrote:
> On Thu, 2014-05-01 at 12:55 -0600, Eric Blake wrote:
>> [meta-comment]
>>
>> I'm not a PHP expert, so I'll let others review the patch itself.  But
>> when contributing patches to libvirt-php.git, it helps if you do:
>>  git config format.subjectprefix "php PATCH"
>> to make it obvious which repo you are targetting with your patch.
>>
> 
> Hi Eric,
> 
> First, I apologize for sending incorrectly formatted patch - I'm still
> learning on how to submit patches to mailing lists properly.

Not a problem - we all had to learn and start somewhere :)  The fact
that you are submitting at all is to be applauded!

>  
> Do you want me to resubmit this patch with proper prefix? Also should I
> mark it as v2, if I was to do so?

No need to repost unless you are changing the patch itself; anything in
the [PATCH] (or by my proposal, [php PATCH]) portion of the subject line
is useful in mail clients, but stripped from what goes into git.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140501/2ec92ef6/attachment-0001.sig>